Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #436] Fix a false positive for Rails/ContentTag #437

Merged
merged 1 commit into from
Feb 15, 2021

Conversation

koic
Copy link
Member

@koic koic commented Feb 8, 2021

Fixes #436.

This PR fixes a false positive for Rails/ContentTag when the first argument is a splat argument.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@koic koic force-pushed the fix_false_positive_for_rails_content_tag branch from 33718bb to cc6a0ab Compare February 8, 2021 11:50
Fixes rubocop#436.

This PR fixes a false positive for `Rails/ContentTag`
when the first argument is a splat argument.
@koic koic force-pushed the fix_false_positive_for_rails_content_tag branch from cc6a0ab to 1bd8ba4 Compare February 9, 2021 20:33
@koic koic merged commit e71791a into rubocop:master Feb 15, 2021
@koic koic deleted the fix_false_positive_for_rails_content_tag branch February 15, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rails/ContentTag Unsafe auto correct deemed safe
1 participant