Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Rails/CreateTableWithTimestamps respect active_storage_variant_records table #570

Conversation

koic
Copy link
Member

@koic koic commented Oct 2, 2021

This PR makes Rails/CreateTableWithTimestamps respect active_storage_variant_records table of db/migrate/*_create_active_storage_tables.active_storage.rb auto-generated by bin/rails active_storage:install even if created_at is not specified.

It suppresses the following offense.

% bin/rails -v
Rails 6.1.4.1

% bin/rails active_storage:install
Copied migration
20210929095151_create_active_storage_tables.active_storage.rb from active_storage

% bundle exec rubocop --only Rails/CreateTableWithTimestamps
Inspecting 1 file
C

Offenses:

db/migrate/20210929095151_create_active_storage_tables.active_storage.rb:28:5:
C: Rails/CreateTableWithTimestamps: Add timestamps when creating a new table.
create_table :active_storage_variant_records do |t| ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1 file inspected, 1 offense detected

As far as I've heard from Rails committers, active_storage_variant_records table hasn't timestamp columns, probably as a result of discussions in the Rails community. If you want to consider the need, please discuss it with https://discuss.rubyonrails.org and give us feedback.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

…t_records` table

This PR makes `Rails/CreateTableWithTimestamps` respect `active_storage_variant_records` table of
`db/migrate/*_create_active_storage_tables.active_storage.rb` auto-generated by `bin/rails active_storage:install`
even if `created_at` is not specified.

It suppresses the following offense.

```console
% bin/rails -v
Rails 6.1.4.1

% bin/rails active_storage:install
Copied migration
20210929095151_create_active_storage_tables.active_storage.rb from active_storage

% bundle exec rubocop --only Rails/CreateTableWithTimestamps
Inspecting 1 file
C

Offenses:

db/migrate/20210929095151_create_active_storage_tables.active_storage.rb:28:5:
C: Rails/CreateTableWithTimestamps: Add timestamps when creating a new table.
create_table :active_storage_variant_records do |t| ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1 file inspected, 1 offense detected
```

As far as I've heard from Rails committers, `active_storage_variant_records` table hasn't timestamp columns,
probably as a result of discussions in the Rails community. If you want to consider the need,
please discuss it with https://discuss.rubyonrails.org and give us feedback.
@koic koic merged commit a4f081a into rubocop:master Oct 3, 2021
@koic koic deleted the make_create_table_with_timestamps_aware_of_ast_variant_records branch October 3, 2021 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant