Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix include value in Rails/AttributeDefaultBlockValue #723

Merged

Conversation

kkitadate
Copy link
Contributor

@kkitadate kkitadate commented Jun 19, 2022

Include value in AttributeDefaultBlockValue is incorrect, so i fix it.
(Although it has already been reported on #339 (comment))


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@koic
Copy link
Member

koic commented Jun 19, 2022

Can you add a changelog entry?

@kkitadate
Copy link
Contributor Author

kkitadate commented Jun 19, 2022

Can you add a changelog entry?

Thank you for your comment. It has completed.
(Should I rebase or squash? Please let me know if necessary)

@kkitadate
Copy link
Contributor Author

kkitadate commented Jun 19, 2022

  • Squashed related commits together.

Due to the above, I will squash the commits.

@kkitadate kkitadate force-pushed the fix-attribute_default_block_value-include branch from 0e67daa to 2dfb59f Compare June 19, 2022 01:13
@kkitadate kkitadate changed the title fix include value in AttributeDefaultBlockValue Fix include value in AttributeDefaultBlockValue Jun 19, 2022
@kkitadate kkitadate changed the title Fix include value in AttributeDefaultBlockValue Fix include value in Rails/AttributeDefaultBlockValue Jun 19, 2022
@kkitadate kkitadate force-pushed the fix-attribute_default_block_value-include branch from 2dfb59f to 496c633 Compare June 19, 2022 02:14
@kkitadate
Copy link
Contributor Author

It seems better to use Department/CopName when describing the cop name.

Thanks for the review. Fixed it.

@koic koic merged commit 5190a68 into rubocop:master Jun 19, 2022
@koic
Copy link
Member

koic commented Jun 19, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants