[Fix #779] Add mail to AllowedMethods of Style/SymbolProc
#806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rubocop#779. This PR adds `mail` to `AllowedMethods` of `Style/SymbolProc`. `define_methods` and `respond_to` inherit from RuboCop core.
koic
force-pushed
the
add_mail_to_allowed_methods_of_style_symbol_proc
branch
from
34cff20
to
2613fee
Compare
koic
added a commit
to koic/rubocop
that referenced
this pull request
Dec 5, 2022
…/SymbolProc` The commit below adds `respond_to` to the config, which looks like a Rails method. rubocop@54ff86e Ruby has method called `respond_to?`, not `respond_to`. So `respond_to` is a Rails API and `respond_to?` doesn't take a block argument. RuboCop core does not depend on Rails, so move the `respond_to` config from RuboCop core to RuboCop Rails. I noticed this by rubocop/rubocop-rails#779. This removed setting was added in RuboCop Rails 2.17. Rails application developers can get this change in the upgrade. rubocop/rubocop-rails#806
Merged
8 tasks
bbatsov
pushed a commit
to rubocop/rubocop
that referenced
this pull request
Dec 5, 2022
…/SymbolProc` The commit below adds `respond_to` to the config, which looks like a Rails method. 54ff86e Ruby has method called `respond_to?`, not `respond_to`. So `respond_to` is a Rails API and `respond_to?` doesn't take a block argument. RuboCop core does not depend on Rails, so move the `respond_to` config from RuboCop core to RuboCop Rails. I noticed this by rubocop/rubocop-rails#779. This removed setting was added in RuboCop Rails 2.17. Rails application developers can get this change in the upgrade. rubocop/rubocop-rails#806
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #779.
This PR adds
mailtoAllowedMethodsofStyle/SymbolProc.define_methodsandrespond_toinherit from RuboCop core.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.