Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #914] Make Style/InverseMethods aware of valid? and invalid? methods #936

Conversation

koic
Copy link
Member

@koic koic commented Feb 19, 2023

Fixes #914.

This commit makes Style/InverseMethods aware of valid? and invalid? methods.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

…invalid?` methods

Fixes rubocop#914.

This commit makes `Style/InverseMethods` aware of `valid?` and `invalid?` methods.
@koic koic merged commit e179054 into rubocop:master Feb 24, 2023
@koic koic deleted the make_style_inverse_methods_aware_of_valid_and_invalid branch February 24, 2023 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cop idea: AR use invalid?/ instead of !valid? or unless @valid?
1 participant