Check for or method in Rails/FindEach cop
#995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masato-bkn
force-pushed
the
improve_rails_find_each
branch
from
936eba0
to
5d79903
Compare
koic
reviewed
May 2, 2023
lib/rubocop/cop/rails/find_each.rb
Outdated
Comment on lines
37
to
38
| all eager_load includes joins left_joins left_outer_joins not preload | ||
| references unscoped where | ||
| references unscoped where or |
There was a problem hiding this comment.
Can you update to order by ASCII position?
- all eager_load includes joins left_joins left_outer_joins not preload
- references unscoped where or
+ all eager_load includes joins left_joins left_outer_joins not or preload
+ references unscoped where
koic
reviewed
May 2, 2023
| @@ -33,6 +33,7 @@ | |||
| it_behaves_like('register_offense', 'unscoped') | |||
| it_behaves_like('register_offense', 'where(name: name)') | |||
| it_behaves_like('register_offense', 'where.not(name: name)') | |||
| it_behaves_like('register_offense', 'where(name: name).or(User.where(age: age))') | |||
There was a problem hiding this comment.
Can you move to between L30 (left_outer_joins) and L31 (preload)?
There was a problem hiding this comment.
https://github.com/rubocop/rubocop-rails/pull/995/files#diff-8b9e38f28a7bdb108efab88f1f3495067c22717be7973a6c73e92d5b0f599287L35
If you want to maintain order defined in SCOPE_METHODS, should I move this between left_outer_joins and or?
There was a problem hiding this comment.
Let's leave the existing one in favor of keeping git blame. Thank you.
masato-bkn
force-pushed
the
improve_rails_find_each
branch
from
5d79903
to
bf38577
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
ormethod to the list of check methods inRails/FindEachcop. Since the cop already checks for the use ofwhereandnot, I thought it would be better to includeoras well.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.