Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autocorrection for Rails/Date #999

Merged
merged 1 commit into from
Jun 17, 2023
Merged

Conversation

r7kamura
Copy link
Contributor

@r7kamura r7kamura commented May 5, 2023

For the same reason as Rails/TimeZone, this autocorrection is unsafe.

As you can see where expect_no_correctionss are added, I could not provide autocorrection for the rule that considers to_time as a violation.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@koic koic merged commit 6bca2ce into rubocop:master Jun 17, 2023
@koic
Copy link
Member

koic commented Jun 17, 2023

Thanks!

@r7kamura r7kamura deleted the date-autocorrect branch June 17, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants