Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rake/Desc should not generate offense for prerequisites declarations #36

Closed
tejasbubane opened this issue May 19, 2021 · 0 comments · Fixed by #37
Closed

Rake/Desc should not generate offense for prerequisites declarations #36

tejasbubane opened this issue May 19, 2021 · 0 comments · Fixed by #37

Comments

@tejasbubane
Copy link
Contributor

tejasbubane commented May 19, 2021

task release: 'changelog:check_clean'

# In another file
desc "Release the gem"
task :release do
  do_something 
end

Rake/Desc should not generate offense for first line because it is not the real definition.

Found in rubocop/rubocop#9813

tejasbubane added a commit to tejasbubane/rubocop-rake that referenced this issue May 20, 2021
tejasbubane added a commit to tejasbubane/rubocop-rake that referenced this issue May 21, 2021
tejasbubane added a commit to tejasbubane/rubocop-rake that referenced this issue Jun 6, 2021
tejasbubane added a commit to tejasbubane/rubocop-rake that referenced this issue Jun 26, 2021
tejasbubane added a commit to tejasbubane/rubocop-rake that referenced this issue Jun 26, 2021
@koic koic closed this as completed in #37 Jun 28, 2021
koic added a commit that referenced this issue Jun 28, 2021
[Fix #36] `Rake/Desc` should not generate offense for prerequisite declarations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant