Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False negatives for Rake/Desc cop #49

Open
ydakuka opened this issue Oct 13, 2023 · 2 comments · May be fixed by #61
Open

False negatives for Rake/Desc cop #49

ydakuka opened this issue Oct 13, 2023 · 2 comments · May be fixed by #61

Comments

@ydakuka
Copy link

ydakuka commented Oct 13, 2023

Actual behavior

task lint: %i[rubocop]

terminal:

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop Rakefile 
Inspecting 1 file
.

1 file inspected, no offenses detected

Rubocop

ydakuka@yauhenid:~/Work/main_app$ bin/rails_docker rubocop -V
1.57.1 (using Parser 3.2.2.4, rubocop-ast 1.29.0, running on ruby 2.7.8) [x86_64-linux]
  - rubocop-capybara 2.19.0
  - rubocop-factory_bot 2.24.0
  - rubocop-performance 1.19.1
  - rubocop-rails 2.21.1
  - rubocop-rake 0.6.0
  - rubocop-rspec 2.24.1
  - rubocop-thread_safety 0.5.1
@pboling
Copy link

pboling commented Nov 9, 2023

What is the expected behavior? The problem is unclear.

Is this the same as #46 ?

@ydakuka
Copy link
Author

ydakuka commented Nov 9, 2023

I have the following code:

task lint: :rubocop

I run rubocop and get offences:

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop Rakefile
Inspecting 1 file
C

Offenses:

Rakefile:3:1: C: Rake/Desc: Describe the task with desc method.
task lint: :rubocop
^^^^^^^^^^^^^^^^^^^

1 file inspected, 1 offense detected

However, if I have the code:

task lint: %i[rubocop]

I will run rubocop and will not receive any offences.

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop Rakefile
Inspecting 1 file
.

1 file inspected, no offenses detected

@ydakuka ydakuka changed the title False positive on Rake/Desc cop False negatives on Rake/Desc cop Feb 23, 2025
@ydakuka ydakuka changed the title False negatives on Rake/Desc cop False negatives for Rake/Desc cop Feb 23, 2025
ydakuka added a commit to ydakuka/rubocop-rake that referenced this issue Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants