Merge pull request #1446 from rubocop/fb-parentheses-arguments

Ignore calls without the first positional argument
rubocop · Oct 29, 2022 · 4a2a155 · 4a2a155
2 parents 1218bc9 + f4bb839
commit 4a2a155
Show file tree

Hide file tree

Showing 3 changed files with 39 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## Master (Unreleased)
 
 - Add `named_only` style to `RSpec/NamedSubject`. ([@kuahyeow])
+- Fix `RSpec/FactoryBot/ConsistentParenthesesStyle` to ignore calls without the first positional argument. ([@pirj])
 
 ## 2.14.2 (2022-10-25)
 

diff --git a/lib/rubocop/cop/rspec/factory_bot/consistent_parentheses_style.rb b/lib/rubocop/cop/rspec/factory_bot/consistent_parentheses_style.rb
@@ -57,9 +57,10 @@ def self.autocorrect_incompatible_with
 
           # @!method factory_call(node)
           def_node_matcher :factory_call, <<-PATTERN
-              (send
-                ${#factory_bot? nil?} %FACTORY_CALLS
-              $...)
+            (send
+              {#factory_bot? nil?} %FACTORY_CALLS
+              {sym str send lvar} _*
+            )
           PATTERN
 
           def on_send(node)

diff --git a/spec/rubocop/cop/rspec/factory_bot/consistent_parentheses_style_spec.rb b/spec/rubocop/cop/rspec/factory_bot/consistent_parentheses_style_spec.rb
@@ -64,6 +64,8 @@
           ^^^^^^^^^^^^^ Prefer method call with parentheses
           build_stubbed_list :user, 10
           ^^^^^^^^^^^^^^^^^^ Prefer method call with parentheses
+          build factory
+          ^^^^^ Prefer method call with parentheses
         RUBY
 
         expect_correction(<<~RUBY)
@@ -72,6 +74,7 @@
           create_list(:user, 10)
           build_stubbed(:user)
           build_stubbed_list(:user, 10)
+          build(factory)
         RUBY
       end
     end
@@ -131,6 +134,20 @@
         RUBY
       end
     end
+
+    it 'flags the call with an explicit receiver' do
+      expect_offense(<<~RUBY)
+        FactoryBot.create :user
+                   ^^^^^^ Prefer method call with parentheses
+      RUBY
+    end
+
+    it 'ignores FactoryBot DSL methods without a first positional argument' do
+      expect_no_offenses(<<~RUBY)
+        create
+        create foo: :bar
+      RUBY
+    end
   end
 
   context 'when EnforcedStyle is :omit_parentheses' do
@@ -187,6 +204,8 @@
           ^^^^^^^^^^^^^ Prefer method call without parentheses
           build_stubbed_list(:user, 10)
           ^^^^^^^^^^^^^^^^^^ Prefer method call without parentheses
+          build(factory)
+          ^^^^^ Prefer method call without parentheses
         RUBY
 
         expect_correction(<<~RUBY)
@@ -195,6 +214,7 @@
           create_list :user, 10
           build_stubbed :user
           build_stubbed_list :user, 10
+          build factory
         RUBY
       end
     end
@@ -313,5 +333,19 @@
         RUBY
       end
     end
+
+    it 'flags the call with an explicit receiver' do
+      expect_offense(<<~RUBY)
+        FactoryBot.create(:user)
+                   ^^^^^^ Prefer method call without parentheses
+      RUBY
+    end
+
+    it 'ignores FactoryBot DSL methods without a first positional argument' do
+      expect_no_offenses(<<~RUBY)
+        create()
+        create(foo: :bar)
+      RUBY
+    end
   end
 end