Skip to content

Commit

Permalink
Merge pull request #1308 from Drowze/verified-double-reference-unsafe
Browse files Browse the repository at this point in the history
Mark RSpec/VerifiedDoubleReference as unsafe
  • Loading branch information
bquorning authored Jun 30, 2022
2 parents 5928b3d + aa00d32 commit 58dd803
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
* Fixed false offense detection in `FactoryBot/CreateList` when a n.times block is including method calls in the factory create arguments. ([@ngouy][])
* Fix error in `RSpec/RSpec/FactoryBot/CreateList` cop for empty block. ([@tejasbubane][])
* Update `RSpec/MultipleExpectations` cop documentation with examples of aggregate_failures use. ([@edgibbs][])
* Declare autocorrect as unsafe for `RSpec/VerifiedDoubleReference`. ([@Drowze][])

## 2.11.1 (2022-05-18)

Expand Down Expand Up @@ -704,3 +705,4 @@ Compatibility release so users can upgrade RuboCop to 0.51.0. No new features.
[@johnny-miyake]: https://github.com/johnny-miyake
[@ngouy]: https://github.com/ngouy
[@edgibbs]: https://github.com/edgibbs
[@Drowze]: https://github.com/Drowze
2 changes: 2 additions & 0 deletions config/default.yml
Original file line number Diff line number Diff line change
Expand Up @@ -783,11 +783,13 @@ RSpec/VariableName:
RSpec/VerifiedDoubleReference:
Description: Checks for consistent verified double reference style.
Enabled: pending
SafeAutoCorrect: false
EnforcedStyle: constant
SupportedStyles:
- constant
- string
VersionAdded: 2.10.0
VersionChanged: '2.12'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/VerifiedDoubleReference

RSpec/VerifiedDoubles:
Expand Down
4 changes: 2 additions & 2 deletions docs/modules/ROOT/pages/cops_rspec.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -4429,9 +4429,9 @@ let(:userFood_2) { 'fettuccine' }

| Pending
| Yes
| Yes
| Yes (Unsafe)
| 2.10.0
| -
| 2.12
|===

Checks for consistent verified double reference style.
Expand Down

0 comments on commit 58dd803

Please sign in to comment.