Merge pull request #1396 from ydah/fix/1395

Fix a wrong AllowedPatterns example in `RSpec/ContextWording`
rubocop · Sep 28, 2022 · 61e154c · 61e154c
2 parents 9c5c65a + 59b6b23
commit 61e154c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/docs/modules/ROOT/pages/cops_rspec.adoc b/docs/modules/ROOT/pages/cops_rspec.adoc
@@ -631,7 +631,7 @@ end
 # .rubocop.yml
 # RSpec/ContextWording:
 #   AllowedPatterns:
-#     - /とき$/
+#     - とき$
 ----
 
 [source,ruby]

diff --git a/lib/rubocop/cop/rspec/context_wording.rb b/lib/rubocop/cop/rspec/context_wording.rb
@@ -43,7 +43,7 @@ module RSpec
       #   # .rubocop.yml
       #   # RSpec/ContextWording:
       #   #   AllowedPatterns:
-      #   #     - /とき$/
+      #   #     - とき$
       #
       # @example
       #   # bad
@@ -92,7 +92,9 @@ def bad_pattern?(description)
         end
 
         def expect_patterns
-          inspected = allowed_patterns.map(&:inspect)
+          inspected = allowed_patterns.map do |pattern|
+            pattern.inspect.gsub(/\A"|"\z/, '/')
+          end
           return inspected.first if inspected.size == 1
 
           inspected << "or #{inspected.pop}"

diff --git a/spec/rubocop/cop/rspec/context_wording_spec.rb b/spec/rubocop/cop/rspec/context_wording_spec.rb
@@ -130,9 +130,9 @@
       end
     end
 
-    context 'when `AllowedPatterns: [/とき$/]`' do
+    context 'when `AllowedPatterns: [とき$]`' do
       let(:cop_config) do
-        { 'Prefixes' => [], 'AllowedPatterns' => [/とき$/] }
+        { 'Prefixes' => [], 'AllowedPatterns' => ['とき$'] }
       end
 
       it 'finds context without `とき` at the ending' do
@@ -159,9 +159,9 @@
       end
     end
 
-    context 'when `Prefixes: [when]` and `AllowedPatterns: [/patterns/]`' do
+    context 'when `Prefixes: [when]` and `AllowedPatterns: [patterns]`' do
       let(:cop_config) do
-        { 'Prefixes' => %w[when], 'AllowedPatterns' => [/patterns/] }
+        { 'Prefixes' => %w[when], 'AllowedPatterns' => ['patterns'] }
       end
 
       it 'finds context without `when` at the beginning and not included ' \