Merge pull request #1509 from r7kamura/feature/require-order

Enable `Style/RequireOrder` cop
rubocop · Dec 11, 2022 · 63908ab · 63908ab
2 parents 0e97cc3 + 7c6ebdd
commit 63908ab
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 36 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -100,6 +100,9 @@ Style/FormatStringToken:
   Exclude:
     - spec/rubocop/**/*.rb
 
+Style/RequireOrder:
+  Enabled: true
+
 # Enable some of RuboCop's pending cops.
 
 Layout/LineContinuationSpacing:

diff --git a/bin/build_config b/bin/build_config
@@ -6,8 +6,8 @@ $LOAD_PATH.unshift(File.join(__dir__, '..', 'lib'))
 require 'yard'
 
 require 'rubocop-rspec'
-require 'rubocop/rspec/description_extractor'
 require 'rubocop/rspec/config_formatter'
+require 'rubocop/rspec/description_extractor'
 
 glob = File.join('lib', 'rubocop', 'cop', 'rspec',
                  '{,capybara,factory_bot,rails}', '*.rb')

diff --git a/lib/rubocop-rspec.rb b/lib/rubocop-rspec.rb
@@ -6,35 +6,39 @@
 require 'rubocop'
 
 require_relative 'rubocop/rspec'
-require_relative 'rubocop/rspec/version'
 require_relative 'rubocop/rspec/inject'
+require_relative 'rubocop/rspec/language/node_pattern'
 require_relative 'rubocop/rspec/node'
+require_relative 'rubocop/rspec/version'
 require_relative 'rubocop/rspec/wording'
-require_relative 'rubocop/rspec/language/node_pattern'
+
+# Dependent on `RuboCop::RSpec::Language::NodePattern`.
 require_relative 'rubocop/rspec/language'
 
 require_relative 'rubocop/rspec/factory_bot/language'
 
-require_relative 'rubocop/cop/rspec/mixin/top_level_group'
-require_relative 'rubocop/cop/rspec/mixin/variable'
+require_relative 'rubocop/cop/rspec/mixin/capybara_help'
+require_relative 'rubocop/cop/rspec/mixin/css_selector'
 require_relative 'rubocop/cop/rspec/mixin/final_end_location'
-require_relative 'rubocop/cop/rspec/mixin/comments_help'
-require_relative 'rubocop/cop/rspec/mixin/empty_line_separation'
 require_relative 'rubocop/cop/rspec/mixin/inside_example_group'
+require_relative 'rubocop/cop/rspec/mixin/metadata'
 require_relative 'rubocop/cop/rspec/mixin/namespace'
-require_relative 'rubocop/cop/rspec/mixin/css_selector'
 require_relative 'rubocop/cop/rspec/mixin/skip_or_pending'
-require_relative 'rubocop/cop/rspec/mixin/capybara_help'
-require_relative 'rubocop/cop/rspec/mixin/metadata'
+require_relative 'rubocop/cop/rspec/mixin/top_level_group'
+require_relative 'rubocop/cop/rspec/mixin/variable'
+
+# Dependent on `RuboCop::Cop::RSpec::FinalEndLocation`.
+require_relative 'rubocop/cop/rspec/mixin/comments_help'
+require_relative 'rubocop/cop/rspec/mixin/empty_line_separation'
 
-require_relative 'rubocop/rspec/concept'
-require_relative 'rubocop/rspec/example_group'
-require_relative 'rubocop/rspec/example'
-require_relative 'rubocop/rspec/hook'
 require_relative 'rubocop/cop/rspec/base'
 require_relative 'rubocop/rspec/align_let_brace'
-require_relative 'rubocop/rspec/factory_bot'
+require_relative 'rubocop/rspec/concept'
 require_relative 'rubocop/rspec/corrector/move_node'
+require_relative 'rubocop/rspec/example'
+require_relative 'rubocop/rspec/example_group'
+require_relative 'rubocop/rspec/factory_bot'
+require_relative 'rubocop/rspec/hook'
 
 RuboCop::RSpec::Inject.defaults!
 

diff --git a/spec/project/project_requires_spec.rb b/spec/project/project_requires_spec.rb
diff --git a/tasks/cops_documentation.rake b/tasks/cops_documentation.rake
@@ -1,9 +1,9 @@
 # frozen_string_literal: true
 
-require 'yard'
 require 'rubocop'
 require 'rubocop-rspec'
 require 'rubocop/cops_documentation_generator'
+require 'yard'
 
 YARD::Rake::YardocTask.new(:yard_for_generate_documentation) do |task|
   task.files = ['lib/rubocop/cop/**/*.rb']