Merge pull request #1387 from ydah/fix/1386

Fix an error for `RSpec/Capybara/SpecificFinders` with no parentheses

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## Master (Unreleased)
 
+* Fix an error for `RSpec/Capybara/SpecificFinders` with no parentheses. ([@ydah][])
+
 ## 2.13.1 (2022-09-12)
 
 * Include config/obsoletion.yml in the gemspec. ([@hosamaly][])

lib/rubocop/cop/rspec/capybara/specific_finders.rb

@@ -76,8 +76,15 @@ def to_options(attrs)
           end
 
           def offense_range(node)
-            range_between(node.loc.selector.begin_pos,
-                          node.loc.end.end_pos)
+            range_between(node.loc.selector.begin_pos, end_pos(node))
+          end
+
+          def end_pos(node)
+            if node.loc.end
+              node.loc.end.end_pos
+            else
+              node.loc.expression.end_pos
+            end
           end
         end
       end

spec/rubocop/cop/rspec/capybara/specific_finders_spec.rb

@@ -12,6 +12,17 @@
     RUBY
   end
 
+  it 'registers an offense when using `find` with no parentheses' do
+    expect_offense(<<~RUBY)
+      find "#some-id"
+      ^^^^^^^^^^^^^^^ Prefer `find_by` over `find`.
+    RUBY
+
+    expect_correction(<<~RUBY)
+      find_by_id 'some-id'
+    RUBY
+  end
+
   it 'registers an offense when using `find` and other args' do
     expect_offense(<<~RUBY)
       find('#some-id', exact_text: 'foo')
@@ -23,6 +34,18 @@
     RUBY
   end
 
+  it 'registers an offense when using `find` and other args ' \
+    'with no parentheses' do
+    expect_offense(<<~RUBY)
+      find '#some-id', exact_text: 'foo'
+      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `find_by` over `find`.
+    RUBY
+
+    expect_correction(<<~RUBY)
+      find_by_id 'some-id', exact_text: 'foo'
+    RUBY
+  end
+
   it 'registers an offense when using `find` with method chain' do
     expect_offense(<<~RUBY)
       find('#some-id').find('#other-id').find('#another-id')