Merge pull request #1438 from rubocop/fix-infinite-correction-loop

Fix infinite correction loop in RSpec/ExampleWording

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## Master (Unreleased)
 
+- Fix autocorrection loop in `RSpec/ExampleWording` for insufficient example wording. ([@pirj])
 - Fix a false positive for `RSpec/NoExpectationExample` when allowed pattern methods with arguments. ([@ydah])
 
 ## 2.14.1 (2022-10-24)

lib/rubocop/cop/rspec/example_wording.rb

@@ -68,20 +68,15 @@ def on_block(node) # rubocop:disable InternalAffairs/NumblockHandler
               add_wording_offense(description_node, MSG_SHOULD)
             elsif message.match?(IT_PREFIX)
               add_wording_offense(description_node, MSG_IT)
-            else
-              check_and_handle_insufficient_examples(description_node)
+            elsif insufficient_docstring?(description_node)
+              add_offense(docstring(description_node),
+                          message: MSG_INSUFFICIENT_DESCRIPTION)
             end
           end
         end
 
         private
 
-        def check_and_handle_insufficient_examples(description)
-          if insufficient_examples.include?(preprocess(text(description)))
-            add_wording_offense(description, MSG_INSUFFICIENT_DESCRIPTION)
-          end
-        end
-
         def add_wording_offense(node, message)
           docstring = docstring(node)
 
@@ -137,6 +132,10 @@ def ignored_words
           cop_config.fetch('IgnoredWords', [])
         end
 
+        def insufficient_docstring?(description_node)
+          insufficient_examples.include?(preprocess(text(description_node)))
+        end
+
         def insufficient_examples
           examples = cop_config.fetch('DisallowedExamples', [])
           examples.map! { |example| preprocess(example) }