Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSpec/Focus does not see the focus attribute on shared_examples #1673

Closed
tmaier opened this issue Jul 23, 2023 · 2 comments · Fixed by #1674
Closed

RSpec/Focus does not see the focus attribute on shared_examples #1673

tmaier opened this issue Jul 23, 2023 · 2 comments · Fixed by #1674
Labels

Comments

@tmaier
Copy link
Contributor

tmaier commented Jul 23, 2023

I had the following code and RSpec/Focus overlooked the focus attribute.

RSpec.shared_examples 'Foable', focus: true do
  it { is_expected.to do things }
end

Gem Versions:

  • rubocop-rspec (2.22.0)
  • rubocop (1.54.2)
  • rubocop-ast (1.29.0)
@pirj
Copy link
Member

pirj commented Jul 24, 2023

Would you like to submit a PR?
It's a matter of adding SharedGroups.all here, extending the doc and adding an example.

@tmaier
Copy link
Contributor Author

tmaier commented Jul 24, 2023

Done @pirj , see #1674

tmaier added a commit to tmaier/rubocop-rspec that referenced this issue Jul 24, 2023
tmaier added a commit to tmaier/rubocop-rspec that referenced this issue Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants