-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not enable RSpec/LetSetup by default #887
Comments
This seems like a duplicate of #94, and I still stand by my response there, which quotes one of the RSpec maintainers:
betterspecs.org is not the official documentation. The official documentation has no recommendation for or against using I am curious to know which specs you have that cannot be written without using |
Thank you! Can you find proof across
The defaults of RuboCop's version and cop enablement policy states that the cops will be enabled on major versions, and the exception to this would only be cops that are really rarely used and not used by many. Other cops, even possibly mutually exclusive, will be enabled, with some default enforced styles. The defaults are carefully picked in such a way that they make sure the code is consistent, gotcha-free, and canonical. I'm not getting into the discussion if |
Please feel free to reopen if there's some evidence that |
I also agree with the OP. |
My first issue here I want to start with words of thankfulness: this project helped me write better rspec tests. Big thanks to all members and contributors!
Talking about the issue:
RSpec/LetSetup
. Across multiple projects I face the same issue: we keep removing this rule. That's why I open this issue, just because I think I'm not the only person in the world who does it.Considering all those examples and official documentation I'd ask to make this code disabled by default.
The text was updated successfully, but these errors were encountered: