Relaxes rubocop-ast dependency locking #1047
Conversation
rubocop-rspec.gemspec
Outdated
| @@ -37,7 +37,7 @@ Gem::Specification.new do |spec| | |||
| } | |||
|
|
|||
| spec.add_runtime_dependency 'rubocop', '~> 0.87' | |||
| spec.add_runtime_dependency 'rubocop-ast', '~> 0.7.1' | |||
| spec.add_runtime_dependency 'rubocop-ast', '~> 0.7' | |||
There was a problem hiding this comment.
There was a specific reason to use 0.7.1 as opposed to 0.7.0. But I guess ~> 0.7 is good either way, and bundler will install 0.7.1+ unless 0.7.0 is already installed.
I hope this explicit dependency specification statement will go away when RuboCop and rubocop-ast hit 1.0, and we hit 2.0.
There was a problem hiding this comment.
After giving it another thought, let's write it as >= 0.7.1, since 0.7.1 released this fix for JRuby.
|
@bquorning Any chance for a |
|
This seems to fail with rubocop-ast 0.8.0, probably want to hold off on merging until that gets figured out. https://app.circleci.com/pipelines/github/rubocop-hq/rubocop-rspec/579/workflows/7af23933-9e4f-434b-9c88-5992c5f1f60c/jobs/17591 |
PhilCoggins
force-pushed
the
relax_rubocop_ast_dependency
branch
from
4e1959b
to
611a8c1
Compare
It only fails against edge rubocop (they’re making ready for v1.0). The other specs pass, also when using rubocop-ast 0.8.0 – e.g. https://app.circleci.com/pipelines/github/rubocop-hq/rubocop-rspec/580/workflows/2d22b1ca-ade8-4e41-a49d-50c80cc3a608/jobs/17602 |
Relaxes rubocop-ast dependency lock from
~> 0.7.1to~> 0.7, fixes #1046Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).If you have created a new cop:
config/default.yml.Enabled: pendinginconfig/default.yml.VersionAddedindefault/config.ymlto the next minor version.If you have modified an existing cop's configuration options:
VersionChangedinconfig/default.ymlto the next major version.