Remove the requirement for a rubocop submodule #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjwp
changed the title
|
Updated now that 0.41.1 is out. |
|
The problem with |
|
Updated again now that 0.41.2 has been released which allows RSpec cops to be enabled/disabled by comments. Also, fixed a test issue with ruby 1.9 now that json 2.0 depends on ruby 2.0 or later. |
|
Thanks @tjwp. Could you rebase onto master? I'd like to merge this |
|
@backus rebased |
|
Thanks @tjwp! |
| @@ -6,6 +6,8 @@ gemspec | |||
|
|
|||
| group :test do | |||
| gem 'codeclimate-test-reporter', require: false | |||
| # json 2.0 requires Ruby >= 2.0 | |||
| gem 'json', '~> 1.8', require: false, platforms: :ruby_19 | |||
There was a problem hiding this comment.
You should be able to remove this. I dropped 1.9.3 support.
|
@tjwp I left one comment. I'll merge once that is fixed |
The latest release of RuboCop (v0.41.1) exposes files to support testing with RSpec.
|
@backus done |
|
Thanks again @tjwp! |
markburns
pushed a commit
to markburns/rubocop-rails-ddd
that referenced
this pull request
Nov 7, 2017
Remove the requirement for a rubocop submodule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest RuboCop version (v0.41.1) exposes files to support testing with RSpec.