Fix ImplicitSubject within third-party aliases #1291
Conversation
| other_cops.dig('RSpec', 'Language', 'Includes', 'Examples') | ||
| .push('epic') |
There was a problem hiding this comment.
Fantastic! 👍
I've spent a while yesterday trying to find or remember how this is stubbed for your reference to no avail.
| @@ -98,6 +107,17 @@ def permits(actions) | |||
| RUBY | |||
| end | |||
|
|
|||
| it 'allows `is_expected` in single statement with an alias' do | |||
There was a problem hiding this comment.
The root problem was that Includes.examples were not considered, so maybe it makes sense to specify this, e.g. "with an alias to Includes.examples".
On a different thought, its_call doesn't seems to be a very fair alias to e.g. it_behaves_like, as the latter creates an example group.
Perhaps it would make sense to change aliasing in saharspec to RSpec/Language/Examples/Regular just like we have it for its.
This would also make this PR redundant, and would also
See palkan/action_policy#138 for more, but there is some specifics to how e.g. success is used there, without a block to justify adding it as an alias to Include.examples.
What do you think?
There was a problem hiding this comment.
It seems legit. I guess we need @zverok's opinion or open a PR on saharspec.
There was a problem hiding this comment.
TBH, it wasn't me who changed it in saharspec, I just trusted the person who did. If there is a better/more right option, I am all open to it. Might be slow to review a PR (I am in Ukraine, if it says anything), but I am working most of the days, so please feel free to submit!
There was a problem hiding this comment.
Ok, I'll preparing a PR on saharspec in the coming days :
changing the third-party configuration is fixing ImplicitSubject but may lead other cops to report false-positives and need more investigations.
--- config/rubocop-rspec.yml
+++ config/rubocop-rspec.yml
@@ -1,13 +1,15 @@
RSpec:
Language:
- Includes:
- Examples:
+ Examples:
+ Regular:
- its_block
- its_call
- its_map
- - fits_block
- - fits_call
- - fits_map
+ Skipped:
- xits_block
- xits_call
- xits_map
+ Focused:
+ - fits_block
+ - fits_call
+ - fits_mapits_call(123) { is_expected.to send_message(task_class, :perform).once }
its_call("203000592") { is_expected.to send_message(task_class, :perform).once }
RSpec/RepeatedDescription: Don't repeat descriptions within an example group. (https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/RepeatedDescription)
its_call(123) { is_expected.to send_message(task_class, :perform).once }
^^^^^^^^^^^^^
RSpec/RepeatedExample: Don't repeat examples within an example group. (https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/RepeatedExample)
its_call(123) { is_expected.to send_message(task_class, :perform).once }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
RSpec/RepeatedDescription: Don't repeat descriptions within an example group. (https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/RepeatedDescription)
its_call("203000592") { is_expected.to send_message(task_class, :perform).once }
^^^^^^^^^^^^^^^^^^^^^
RSpec/RepeatedExample: Don't repeat examples within an example group. (https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/RepeatedExample)
its_call("203000592") { is_expected.to send_message(task_class, :perform).once }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
There was a problem hiding this comment.
@pirj do you ask if the following config is equal to the one that I made in the PR to saharspec?
RSpec:
Language:
Examples:
Regular:
- its_block
- its_call
- its_map
Skipped:
- xits_block
- xits_call
- xits_map
Focused:
- fits_block
- fits_call
- fits_mapI think so, I checked this config and it works well for all my scenarios.
|
I'm closing this, as this can be fixed on |
Fix #1290
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).