Fix a false negative for RSpec/Capybara/VisibilityMatcher with negative matcher
#1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydah
changed the title
ArgumentError with RSpec/Capybara/VisibilityMatcher where :visible is an invalid optionRSpec/Capybara/VisibilityMatcher with negative matcher.
ydah
changed the title
RSpec/Capybara/VisibilityMatcher with negative matcher.RSpec/Capybara/VisibilityMatcher with negative matcher
Darhazer
reviewed
Sep 21, 2022
ydah
force-pushed
the
fix/visibilly_matcher
branch
from
b8883bc to
ccfb743
Compare
Darhazer
reviewed
Sep 21, 2022
CHANGELOG.md
Outdated
| @@ -3,6 +3,8 @@ | |||
| ## Master (Unreleased) | |||
|
|
|||
| * Fix an error for `RSpec/Capybara/SpecificFinders` with no parentheses. ([@ydah][]) | |||
| * Exclude methods that raise `ArgumentError` with `RSpec/Capybara/VisibilityMatcher` where `:visible` is an invalid option. ([@ydah][]) | |||
There was a problem hiding this comment.
Perhaps it's better to list which elements were excluded.
There was a problem hiding this comment.
That looks better. I have modified it to list it.
There was a problem hiding this comment.
I think now you have to entries for the same commit
There was a problem hiding this comment.
Oops, looks like the second commit contained an unnecessary entry. Fixed it.
| have_unchecked_field | ||
| have_text | ||
| have_content | ||
| have_button have_checked_field have_css have_field have_link |
There was a problem hiding this comment.
WDYT of such an approach:
%w[button
checked_field
css
field
link
select
selector
table
unchecked_field
xpath].flat_map { |element| ["have_#{element}", "have_no_#{element}"]}
That way we'd never forget to add the no_ version
There was a problem hiding this comment.
We had to make it a symbol, so I modified it a bit, how do you like it?
…h `RSpec/Capybara/VisibilityMatcher` where `:visible` is an invalid option
If `:visible` is specified for `have_text` and its alias method,
`have_content`, it will result in an `ArgumentError` as follows.
Therefore, This PR is excluded `have_text` and `have_content`
for `RSpec/Capybara/VisibilityMatcher`.
```
Failure/Error: expect(page).to have_text('a', visible: true)
ArgumentError:
Invalid option(s) :visible, should be one of :count, :minimum, :maximum, :between, :wait, :exact, :normalize_ws
# ./spec/capybara/sandbox_spec.rb:20:in `block (2 levels) in <top (required)>'
Failure/Error: expect(page).to have_content('a', visible: true)
ArgumentError:
Invalid option(s) :visible, should be one of :count, :minimum, :maximum, :between, :wait, :exact, :normalize_ws
# ./spec/capybara/sandbox_spec.rb:68:in `block (2 levels) in <top (required)>'
```
ydah
force-pushed
the
fix/visibilly_matcher
branch
from
ccfb743 to
ff1254b
Compare
…tive matchers Fix: rubocop#1390
ydah
force-pushed
the
fix/visibilly_matcher
branch
from
ff1254b to
567adbe
Compare
Darhazer
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem with
RSpec/Capybara/VisibilityMatcherIt is difficult to separate the PRs, and we have divided them into two commits in the PR and as a changelog, but please let us know if we need to separate the PRs.
@ commit 1 9778492
If
:visibleis specified forhave_textand its alias method,have_content, it will result in anArgumentErroras follows.Therefore, This PR is excluded
have_textandhave_contentforRSpec/Capybara/VisibilityMatcher.@ commit 2 b8883bc
Fix: #1390
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).If you have created a new cop:
config/default.yml.Enabled: pendinginconfig/default.yml.Enabled: truein.rubocop.yml.VersionAddedindefault/config.ymlto the next minor version.If you have modified an existing cop's configuration options:
VersionChangedinconfig/default.ymlto the next major version.