Add SubjectStub cop #161
Merged
Add SubjectStub cop #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
backus
force-pushed
the
feature/Stubject
branch
5 times, most recently
from
b2cfa7e to
d050adb
Compare
|
@andyw8 not ready for prime time at all but this should give you an idea of the bare minimum complexity for a cop like this |
backus
force-pushed
the
feature/Stubject
branch
3 times, most recently
from
c8dc02c to
8208d81
Compare
|
I think this is actually pretty stable now. Running this against a lot of local projects yielded good results. |
backus
force-pushed
the
feature/Stubject
branch
3 times, most recently
from
ecb6c3e to
162b662
Compare
backus
force-pushed
the
feature/Stubject
branch
from
fbaa79f to
9b361be
Compare
Closes #144
backus
force-pushed
the
feature/Stubject
branch
from
3ffdec6 to
5d76715
Compare
backus
force-pushed
the
feature/Stubject
branch
from
5df089a to
4953398
Compare
|
@turino As this PR is already merged, would you mind creating an issue for these enhancements? I agree they'd both be useful. |
|
@andyw8 I'd be happy to |
markburns
pushed a commit
to markburns/rubocop-rails-ddd
that referenced
this pull request
Nov 7, 2017
Add SubjectStub cop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.