Revert an change that would conceal unintentional RSpec syntax #1985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically:
expect { ... }.to change { ... }.by(...) and change { ... }.by(...)
Here the usage of `and` is incorrect, as RSpec does not (and can't
reasonably) support it.
Compound should use the `and` method, not the operator, or the `&`. Same
for `.or` and `|`.
bquorning
approved these changes
Oct 25, 2024
bquorning
approved these changes
Oct 25, 2024
ydah
approved these changes
Oct 26, 2024
|
Thank you! |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically:
Here the usage of
andis incorrect, as RSpec does not (and can't reasonably) support it.Compound should use the
andmethod, not the operator, or the&. Same for.orand|.Related: #1984 #1983
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).