Fix false positive for RSpec/EmptyExampleGroup cop with iterator and simple conditional

[lovro-bikic]

Fixes a false positive for RSpec/EmptyExampleGroup with iterator and simple conditional (one that doesn't have multiple statements, so it's not wrapped in a begin node).

Previously, code such as:

context 'foo' do
  [1, 2, 3].each do |x|
    if x.odd?
      it { expect(x).to be_odd }
    else
      it { expect(x).to be_even }
    end
  end
end

would register as an offense. With this patch, the offense isn't registered anymore.

---

Before submitting the PR make sure the following are checked:

• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• Updated documentation.
• Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
• The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

[pirj]

Thank you

[pirj]

Just for clarity, does it make sense to use page in the condition? Otherwise, why it's inside the loop, and it's not the loop inside the conditional block?

[lovro-bikic]

I guess so, I didn't think about it much because I copied this from another example. I've updated it now to use page in the expectation, as in some other examples.