Disable MessageExpectation cop #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@backus Where do we put the configuration for disabled cops? |
|
@bquorning. Lets just toss it in the default.yml for now. I don't think we need to maintain two files yet |
|
@bquorning once this is merged can you do a minor version bump and release to rubygems? |
|
What I meant was: how do I get a green build? ;-) |
|
oh haha. I guess we need to update that test. |
|
@bquorning the failing test can be updated to: it 'includes Enabled: true for every cop' do
expect(cop_configuration('Enabled')).to all(be(true).or(be(false)))
endBasically we are asserting that it is present and a boolean |
bquorning
force-pushed
the
disable-message_expectation-cop
branch
from
a3e463c to
068d1ef
Compare
|
@backus Was that a +1? |
backus
approved these changes
Oct 27, 2016
|
Yeah sorry I was on my phone. |
markburns
pushed a commit
to markburns/rubocop-rails-ddd
that referenced
this pull request
Nov 7, 2017
…n-cop Disable MessageExpectation cop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users have expressed confusion over this cop; see