Add autocorrect for RSpec/ExpectActual

[dduugg]

Adds an autocorrect to RSpec/ExpectActual, swapping the arguments to expect and eq when possible.

---

Before submitting the PR make sure the following are checked:

• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• Added an entry to the changelog if the new code introduces user-observable changes.
• The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

[pirj]

Looks good to me.
Thanks for the contribution!

[pirj]

Few minor notes.

[pirj]

Maybe also :==, :eql?, :equal?, and :be?
A culprit with :be is that it might not have an argument:

expect(3).to be

[dduugg]

Hi @pirj, thanks for the suggestions. Could I trouble you to provide examples using the first three methods? I interpreted your suggestion as applying like so:

expect(123).to ==(bar)
expect(123).to eql?(bar)
expect(123).to equal?(bar)

…but that doesn't appear to be valid:

     Failure/Error: expect(123).to equal?(123)

     ArgumentError:
       The expect syntax does not support operator matchers, so you must pass a matcher to `#to`.

[pirj]

My bad. Should of course be:

expect(123).to be
expect(123).to be == 123
expect(123).to eql(123)
expect(123).to equal(123)

Thanks for the extra care.

[pirj]

Do you need a hand with this @dduugg ? Please let me know if you get stuck with something.

[dduugg]

Hi @pirj I'll close this until I have more bandwidth to cover the various examples. It seemed much simpler when I was able to autocorrect the cop's spec and my code with ease 😸