Take metadata into account in RSpec/RepeatedDescription cop
#874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazycoder9
force-pushed
the
fix/repeated_example_description
branch
from
2000093 to
3fb09b9
Compare
pirj
approved these changes
Feb 9, 2020
|
|
||
| grouped_examples | ||
| .select { |description, group| description && group.size > 1 } | ||
| .select { |signatures, group| !signatures.empty? && group.size > 1 } |
Member
There was a problem hiding this comment.
Maybe signatures.any??
In this case compact below becomes redundant.
pirj
changed the title
RSpec/RepeatedDescription cop
Member
|
@bquorning @Darhazer we have plenty of changes to release! |
Darhazer
approved these changes
Feb 10, 2020
| RUBY | ||
| end | ||
|
|
||
| it 'does not flag examples if metadata is different' do |
Member
There was a problem hiding this comment.
what if there is the same metatada? with same description? With different descriptions?
I would convert this to a context and add a couple of more examples
Contributor
Author
There was a problem hiding this comment.
Added two more tests
Member
Unfortunately, I don't have access to rubygems to push releases. But I agree, let's release a new version after this one is merged |
Collaborator
|
I’ll release a new version after this PR has been merged. As mentioned by @Darhazer, we should probably have a few more specs first. |
lazycoder9
force-pushed
the
fix/repeated_example_description
branch
from
3fb09b9 to
5024a13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #873
RSpec/RepeatedDescriptionwill take metadata into account and will not flag examples like belowBefore submitting the PR make sure the following are checked:
master(if not - rebase it).bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).If you have created a new cop:
config/default.yml.