Disable MessageExpectation cop

Users have expressed confusion over this cop; see - rubocop/rubocop-rspec#23 - rubocop/rubocop-rspec#169 - rubocop/rubocop-rspec#218 - rubocop/rubocop-rspec#224 - rubocop/rubocop-rspec#229
rubocop · Oct 27, 2016 · c8bab6b · c8bab6b
1 parent cdf4d97
commit c8bab6b
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
 * Optinally ignore method names in the `describe` argument when running the `FilePath` cop. ([@bquorning][])
 * Fix regression in how `FilePath` converts alphanumeric class names into paths. ([@bquorning][])
 * Add `ImplicitExpect` cop for enforcing `should` vs. `is_expected.to`. ([@backus][])
+* Disable `MessageExpectation` cop in the default configuration. ([@bquorning][])
 
 ## 1.7.0 (2016-08-24)
 

diff --git a/config/default.yml b/config/default.yml
@@ -97,7 +97,7 @@ RSpec/MessageChain:
 
 RSpec/MessageExpectation:
   Description: Checks for consistent message expectation style.
-  Enabled: true
+  Enabled: false
   EnforcedStyle: allow
   SupportedStyles:
   - allow

diff --git a/spec/project/default_config_spec.rb b/spec/project/default_config_spec.rb
@@ -47,6 +47,6 @@ def cop_configuration(config_key)
   end
 
   it 'includes Enabled: true for every cop' do
-    expect(cop_configuration('Enabled')).to all(be(true))
+    expect(cop_configuration('Enabled')).to all(be(true).or(be(false)))
   end
 end