Merge pull request #273 from jonas054/fix_multiline_hash_literal_bug

Always allow line breaks inside hash literal braces.

CHANGELOG.md

@@ -34,6 +34,7 @@
 * [#246](https://github.com/bbatsov/rubocop/issues/246) - correct handling of unicode escapes within double quotes
 * Fix crashes in Blocks, CaseEquality, CaseIndentation, ClassAndModuleCamelCase, ClassMethods, CollectionMethods, and ColonMethodCall.
 * [#263](https://github.com/bbatsov/rubocop/issues/263) - do not check for space around operators called with method syntax
+* [#271](https://github.com/bbatsov/rubocop/issues/271) - always allow line breaks inside hash literal braces
 
 ## 0.8.2 (06/05/2013)
 

lib/rubocop/cop/surrounding_space.rb

@@ -256,6 +256,7 @@ def check(t1, t2)
         types = [t1, t2].map(&:type)
         braces = [:tLBRACE, :tRCURLY]
         return if types == braces || (braces - types).size == 2
+        return if t1.pos.line < t2.pos.line # No offence if line break inside.
         has_space = space_between?(t1, t2)
         is_offence, word = if self.class.config['EnforcedStyleIsWithSpaces']
                              [!has_space, 'missing']

spec/rubocop/cops/space_inside_hash_literal_braces_spec.rb

@@ -53,6 +53,17 @@ module Cop
         expect(sihlb.offences.map(&:message)).to be_empty
       end
 
+      it 'accepts multiline hashes even if configured for no space' do
+        SpaceInsideHashLiteralBraces.config['EnforcedStyleIsWithSpaces'] =
+          false
+        inspect_source(sihlb,
+                       ['h = {',
+                        '      a: 1,',
+                        '      b: 2,',
+                        '}'])
+        expect(sihlb.offences).to be_empty
+      end
+
       it 'accepts empty hashes without spaces by default' do
         inspect_source(sihlb, ['h = {}'])
         expect(sihlb.offences).to be_empty