Fix a false positive for Style/ArgumentsForwarding

[koic]

Resolves #12618 (comment).

This PR fixes a false positive for Style/ArgumentsForwarding when using block arg forwarding with positional arguments forwarding to within block.

---

Before submitting the PR make sure the following are checked:

• The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
• Wrote good commit messages.
• Commit message starts with [Fix #issue-number] (if the related issue exists).
• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
• Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

[znz]

I tried this branch.
And it seems Naming/BlockForwarding does not work with EnforcedStyle: explicit.

% docker run --rm -it ruby:3.1 /bin/bash
root@40fdbcc3b8a9:/# bundle init
Writing new Gemfile to //Gemfile
root@40fdbcc3b8a9:/# cat > Gemfile
# frozen_string_literal: true
source "https://rubygems.org"
gem 'rubocop', git: 'https://github.com/koic/rubocop', branch: 'fix_false_positive_for_style_arguments_forwarding'
root@40fdbcc3b8a9:/# bundle i
Fetching https://github.com/koic/rubocop
Resolving dependencies...Fetching gem metadata from https://rubygems.org/..
...........
Fetching ast 2.4.2
Using bundler 2.3.26
Fetching json 2.7.1
Installing ast 2.4.2
Installing json 2.7.1 with native extensions
Fetching language_server-protocol 3.17.0.3
Installing language_server-protocol 3.17.0.3
Fetching parallel 1.24.0
Installing parallel 1.24.0
Fetching racc 1.7.3
Installing racc 1.7.3 with native extensions
Fetching rainbow 3.1.1
Installing rainbow 3.1.1
Fetching regexp_parser 2.9.0
Installing regexp_parser 2.9.0
Fetching rexml 3.2.6
Installing rexml 3.2.6
Fetching ruby-progressbar 1.13.0
Installing ruby-progressbar 1.13.0
Fetching unicode-display_width 2.5.0
Installing unicode-display_width 2.5.0
Fetching parser 3.3.0.4
Installing parser 3.3.0.4
Fetching rubocop-ast 1.30.0
Installing rubocop-ast 1.30.0
Using rubocop 1.60.1 from https://github.com/koic/rubocop (at fix_false_positive_for_style_arguments_forwarding@4b6ad5c)
Bundle complete! 1 Gemfile dependency, 14 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.
root@40fdbcc3b8a9:/# cat > .rubocop.yml
AllCops:
  TargetRubyVersion: '3.1'
  NewCops: enable

Naming/BlockForwarding:
  EnforcedStyle: explicit
root@40fdbcc3b8a9:/# cat > b.rb
C.class_eval do
  def foo(a=false, &block)
    bar(a, 1, &block)
  end
end
root@40fdbcc3b8a9:/# bundle exec rubocop -a b.rb
Inspecting 1 file
C

Offenses:

.rb:1:1: C: [Correctable] Style/FrozenStringLiteralComment: Missing frozen string literal comment.
C.class_eval do
^
.rb:2:11: C: Naming/MethodParameterName: Method parameter must be at least 3 characters long.
  def foo(a = false, &)
          ^
.rb:2:11: C: Style/OptionalBooleanParameter: Prefer keyword arguments for arguments with a boolean default value; use a: false instead of a = false.
  def foo(a = false, &)
          ^^^^^^^^^
.rb:2:12: C: [Corrected] Layout/SpaceAroundEqualsInParameterDefault: Surrounding space missing in default value assignment.
  def foo(a=false, &block)
           ^
.rb:2:20: C: [Corrected] Style/ArgumentsForwarding: Use anonymous block arguments forwarding (&).
  def foo(a=false, &block)
                   ^^^^^^
.rb:3:15: C: [Corrected] Style/ArgumentsForwarding: Use anonymous block arguments forwarding (&).
    bar(a, 1, &block)
              ^^^^^^

1 file inspected, 6 offenses detected, 3 offenses corrected, 1 more offense can be corrected with `rubocop -A`
root@40fdbcc3b8a9:/# cat b.rb
C.class_eval do
  def foo(a = false, &)
    bar(a, 1, &)
  end
end

And rubocop 1.60.1 causes Infinite loop detected in /b.rb and caused by Style/ArgumentsForwarding -> Naming/BlockForwarding, Style/ArgumentsForwarding.

% docker run --rm -it ruby:3.1 /bin/bash
root@7d574f957d6a:/# gem i rubocop
Fetching rainbow-3.1.1.gem
Fetching ruby-progressbar-1.13.0.gem
Fetching regexp_parser-2.9.0.gem
Fetching unicode-display_width-2.5.0.gem
Fetching rubocop-ast-1.30.0.gem
Fetching ast-2.4.2.gem
Fetching parallel-1.24.0.gem
Fetching rubocop-1.60.1.gem
Fetching parser-3.3.0.4.gem
Fetching language_server-protocol-3.17.0.3.gem
Successfully installed unicode-display_width-2.5.0
Successfully installed ruby-progressbar-1.13.0
Successfully installed ast-2.4.2
Successfully installed parser-3.3.0.4
Successfully installed rubocop-ast-1.30.0
Successfully installed regexp_parser-2.9.0
Successfully installed rainbow-3.1.1
Successfully installed parallel-1.24.0
Successfully installed language_server-protocol-3.17.0.3
Successfully installed rubocop-1.60.1
10 gems installed
root@7d574f957d6a:/# cat > .rubocop.yml
AllCops:
  TargetRubyVersion: '3.1'
  NewCops: enable

Naming/BlockForwarding:
  EnforcedStyle: explicit
root@7d574f957d6a:/# cat > b.rb
# bad
def foo(&)
  bar(&)
end

# good
def foo(&block)
  bar(&block)
end
root@7d574f957d6a:/# rubocop b.rb
Inspecting 1 file
W

Offenses:

.rb:1:1: C: [Correctable] Style/FrozenStringLiteralComment: Missing frozen string literal comment.
# bad
^
.rb:2:9: C: [Correctable] Naming/BlockForwarding: Use explicit block forwarding.
def foo(&)
        ^
.rb:2:9: C: [Correctable] Style/ArgumentsForwarding: Use anonymous block arguments forwarding (&).
def foo(&)
        ^
.rb:3:7: C: [Correctable] Naming/BlockForwarding: Use explicit block forwarding.
  bar(&)
      ^
.rb:3:7: C: [Correctable] Style/ArgumentsForwarding: Use anonymous block arguments forwarding (&).
  bar(&)
      ^
.rb:7:1: W: Lint/DuplicateMethods: Method Object#foo is defined at both .rb:2 and .rb:7.
def foo(&block)
^^^^^^^
.rb:7:9: C: [Correctable] Style/ArgumentsForwarding: Use anonymous block arguments forwarding (&).
def foo(&block)
        ^^^^^^
.rb:8:7: C: [Correctable] Style/ArgumentsForwarding: Use anonymous block arguments forwarding (&).
  bar(&block)
      ^^^^^^

1 file inspected, 8 offenses detected, 7 offenses autocorrectable
root@7d574f957d6a:/# rubocop -a b.rb
Inspecting 1 file
C

Offenses:

.rb:2:9: C: [Corrected] Naming/BlockForwarding: Use explicit block forwarding.
def foo(&)
        ^
.rb:2:9: C: [Corrected] Style/ArgumentsForwarding: Use anonymous block arguments forwarding (&).
def foo(&)
        ^
.rb:3:7: C: [Corrected] Naming/BlockForwarding: Use explicit block forwarding.
  bar(&)
      ^
.rb:3:7: C: [Corrected] Style/ArgumentsForwarding: Use anonymous block arguments forwarding (&).
  bar(&)
      ^
.rb:7:9: C: [Corrected] Naming/BlockForwarding: Use explicit block forwarding.
def foo(&)
        ^
.rb:7:9: C: [Corrected] Style/ArgumentsForwarding: Use anonymous block arguments forwarding (&).
def foo(&block)
        ^^^^^^
.rb:8:7: C: [Corrected] Naming/BlockForwarding: Use explicit block forwarding.
  bar(&)
      ^
.rb:8:7: C: [Corrected] Style/ArgumentsForwarding: Use anonymous block arguments forwarding (&).
  bar(&block)
      ^^^^^^

0 files inspected, 8 offenses detected, 8 offenses corrected
Infinite loop detected in /b.rb and caused by Style/ArgumentsForwarding -> Naming/BlockForwarding, Style/ArgumentsForwarding
/usr/local/bundle/gems/rubocop-1.60.1/lib/rubocop/runner.rb:332:in `check_for_infinite_loop'
/usr/local/bundle/gems/rubocop-1.60.1/lib/rubocop/runner.rb:315:in `block in iterate_until_no_changes'
/usr/local/bundle/gems/rubocop-1.60.1/lib/rubocop/runner.rb:314:in `loop'
/usr/local/bundle/gems/rubocop-1.60.1/lib/rubocop/runner.rb:314:in `iterate_until_no_changes'
/usr/local/bundle/gems/rubocop-1.60.1/lib/rubocop/runner.rb:283:in `do_inspection_loop'
/usr/local/bundle/gems/rubocop-1.60.1/lib/rubocop/runner.rb:164:in `block in file_offenses'
/usr/local/bundle/gems/rubocop-1.60.1/lib/rubocop/runner.rb:189:in `file_offense_cache'
/usr/local/bundle/gems/rubocop-1.60.1/lib/rubocop/runner.rb:163:in `file_offenses'
/usr/local/bundle/gems/rubocop-1.60.1/lib/rubocop/runner.rb:154:in `process_file'
/usr/local/bundle/gems/rubocop-1.60.1/lib/rubocop/runner.rb:135:in `block in each_inspected_file'
/usr/local/bundle/gems/rubocop-1.60.1/lib/rubocop/runner.rb:134:in `each'
/usr/local/bundle/gems/rubocop-1.60.1/lib/rubocop/runner.rb:134:in `reduce'
/usr/local/bundle/gems/rubocop-1.60.1/lib/rubocop/runner.rb:134:in `each_inspected_file'
/usr/local/bundle/gems/rubocop-1.60.1/lib/rubocop/runner.rb:120:in `inspect_files'
/usr/local/bundle/gems/rubocop-1.60.1/lib/rubocop/runner.rb:73:in `run'
/usr/local/bundle/gems/rubocop-1.60.1/lib/rubocop/cli/command/execute_runner.rb:26:in `block in execute_runner'
/usr/local/bundle/gems/rubocop-1.60.1/lib/rubocop/cli/command/execute_runner.rb:52:in `with_redirect'
/usr/local/bundle/gems/rubocop-1.60.1/lib/rubocop/cli/command/execute_runner.rb:25:in `execute_runner'
/usr/local/bundle/gems/rubocop-1.60.1/lib/rubocop/cli/command/execute_runner.rb:17:in `run'
/usr/local/bundle/gems/rubocop-1.60.1/lib/rubocop/cli/command.rb:11:in `run'
/usr/local/bundle/gems/rubocop-1.60.1/lib/rubocop/cli/environment.rb:18:in `run'
/usr/local/bundle/gems/rubocop-1.60.1/lib/rubocop/cli.rb:118:in `run_command'
/usr/local/bundle/gems/rubocop-1.60.1/lib/rubocop/cli.rb:125:in `execute_runners'
/usr/local/bundle/gems/rubocop-1.60.1/lib/rubocop/cli.rb:51:in `block in run'
/usr/local/bundle/gems/rubocop-1.60.1/lib/rubocop/cli.rb:77:in `profile_if_needed'
/usr/local/bundle/gems/rubocop-1.60.1/lib/rubocop/cli.rb:43:in `run'
/usr/local/bundle/gems/rubocop-1.60.1/exe/rubocop:19:in `block in <top (required)>'
/usr/local/lib/ruby/3.1.0/benchmark.rb:311:in `realtime'
/usr/local/bundle/gems/rubocop-1.60.1/exe/rubocop:19:in `<top (required)>'
/usr/local/bundle/bin/rubocop:25:in `load'
/usr/local/bundle/bin/rubocop:25:in `<main>'
root@7d574f957d6a:/# rubocop -V
1.60.1 (using Parser 3.3.0.4, rubocop-ast 1.30.0, running on ruby 3.1.4) [aarch64-linux]

[koic]

@znz Thank you for the checking. This seems to be an issue separate from the purpose of this PR. Can you open a new issue for it?

[znz]

@koic I created #12632