Fix Style/ParallelAssignment #2488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apart from the stylistic issues uncovered by RuboCop, the changes look fine. |
alexdowad
force-pushed
the
fix_parallel
branch
from
67f8f53 to
b32789a
Compare
|
Looks good to me. Thanks for implementing this fix. |
...The stylistic issues are fixed.
And thank you for all your work as well, @rrosenblum! |
alexdowad
force-pushed
the
fix_parallel
branch
from
b32789a to
dfc99df
Compare
|
The changes look good to me as well. You'll have to rebase. |
alexdowad
force-pushed
the
fix_parallel
branch
from
dfc99df to
77ee7d3
Compare
|
Slipped in another bug fix. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2464.