Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused doubled methods #3509

Merged
merged 1 commit into from
Sep 19, 2016
Merged

Remove unused doubled methods #3509

merged 1 commit into from
Sep 19, 2016

Conversation

backus
Copy link
Contributor

@backus backus commented Sep 19, 2016 •
edited
Loading

I found a few test doubles that unnecessarily define methods that are not required to make the test pass.

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Used the same coding conventions as the rest of the project.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • All tests are passing.
  • The new code doesn't generate RuboCop offenses.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.

These methods can be safely removed from their test doubles without
breaking the test case

@backus
Remove unused doubled methods
eae9f32 
These methods can be safely removed from their test doubles without
breaking the test case
@bbatsov bbatsov merged commit ff84316 into rubocop:master Sep 19, 2016
@bbatsov
Copy link
Collaborator

bbatsov commented Sep 19, 2016

👍

@backus backus deleted the refactor/remove-unused-double-methods branch September 19, 2016 07:13
mikezter added a commit to mikezter/rubocop that referenced this pull request Sep 28, 2016
@mikezter
Merge remote-tracking branch 'bbatsov/master'
ddf05ec 
* bbatsov/master: (80 commits)
  [Fix rubocop#3540] Make `Style/GuardClause` register offense for instance & singleton methods
  [Fix rubocop#3436] issue related to Rails/SaveBang when returning non-bang call from the parent method
  Allow `#to_yml` to produce single-quoted strings
  Add support for StyleGuideBaseURL and update rules
  Add spec for the existing style guide URL implementation
  Fix the changelog
  Edited regular expression for normal case to fix issues rubocop#3514 and rubocop#3516 (rubocop#3524)
  Add a rake task for generation a new cop (rubocop#3533)
  [Fix rubocop#3510] Various bug fixes for SafeNavigation (rubocop#3517)
  [Fix rubocop#3512] Change error message of `Lint/UnneededSplatExpansion` for array (rubocop#3526)
  Fix false positive in `Lint/AssignmentInCondition` (rubocop#3520) (rubocop#3529)
  Rename a mismatched filename (rubocop#3523)
  Fix a broken changelog entry
  [Fix rubocop#3511] Style/TernaryParentheses false positive (rubocop#3513)
  Fix the release notes for 0.43
  Cut 0.43.0
  [Fix rubocop#3462] Don't flag single-line methods
  Fix false negatives in `Rails/NotNullColumn` cop (rubocop#3508)
  Remove unused doubled methods (rubocop#3509)
  [Fix rubocop#3485] Make OneLineConditional cop ignore empty else (rubocop#3487)
  ...
Neodelf pushed a commit to Neodelf/rubocop that referenced this pull request Oct 15, 2016
@backus @Neodelf
Remove unused doubled methods (rubocop#3509)
aa27c62 
These methods can be safely removed from their test doubles without
breaking the test case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@backus @bbatsov