Align hash special case #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are 'accepts' examples where there's a syntax error in the inspected source, which means that the code is never actually inspected. The example passes, but we haven't checked anything.
Multiple key-value pairs per line in a multi-line hash was not supported correctly. Alignment can only be checked when each key/value is on a separate line, so we ignore these cases.
|
Nice catch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that a comma was missing in a spec example that was instroduced in #514. That syntax error was silently ignored and we missed the fact that we didn't support multi-values per line, multi-line hash syntax alignment of the table or separator kind.