Add a rule about a newline at eof #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Source files should end with a newline, not a blank line. |
|
@bbatsov agreed. I've fixed this rule |
|
@phts Looks good. Please, squash the two commits into one. |
|
@bbatsov Done |
bbatsov
added a commit
that referenced
this pull request
Feb 17, 2014
Add a rule about a newline at eof
|
Thanks. |
|
I do agree with this rule 100%, but I would like to know the why. In my case I consider it beneficial because it leads to cleaner diffs in version control systems. But that reason does not seem to be good enough for other rules that have been suggested but not yet accepted (such as trailing commas in multi-line array literals, like #273 and #290). So clearly, there could be other reasons aside from the VCS argument. If so, which are they? |
marocchino
pushed a commit
to marocchino/ruby-style-guide
that referenced
this pull request
Aug 11, 2015
Add a rule about a newline at eof
shyouhei
pushed a commit
to shyouhei/ruby-style-guide
that referenced
this pull request
Nov 11, 2015
Add a rule about a newline at eof
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken from http://github.com/styleguide/ruby