Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace java_kind_of? with kind_of? to support JRuby-9.3.0.0 #156

Merged

Conversation

ThomasKoppensteiner
Copy link
Contributor

Fixes Issue: #155

@ThomasKoppensteiner
Copy link
Contributor Author

@michaelklishin can you please have a look?

@ThomasKoppensteiner
Copy link
Contributor Author

@olleolleolle I have seen your comment on the JRuby issue (jruby/jruby#6862 (comment)).

FYI: The test for the long header conversion (https://github.com/ruby-amqp/march_hare/blob/master/spec/higher_level_api/integration/basic_consume_spec.rb#L158) worked for me locally with this branch (JRuby-9.3.0.0 and .kind_of?).

@olleolleolle
Copy link
Contributor

@ThomasKoppensteiner That sounds good. I'm in favour of the change.

In order for it to be visible for everyone, I'd love to have CI runs.

@headius
Copy link

headius commented Oct 5, 2021

Sorry for the inconvenience removing this method! It has been around since very old Java integration days, but since we started mimicking the Java class hierarchy with Ruby types (like 15 years ago) it has not been needed. I guess you really never can delete anything!

Let us know if there are any further issues here.

@ThomasKoppensteiner
Copy link
Contributor Author

Rebase master after #158 is merged.

Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michaelklishin michaelklishin merged commit 6519d5a into ruby-amqp:master Oct 8, 2021
@michaelklishin
Copy link
Member

Thank you! That was easier than I expected it to ;)

@ThomasKoppensteiner
Copy link
Contributor Author

ThomasKoppensteiner commented Oct 8, 2021

Thank you for merging the PRs.
When will you release the fix?

@michaelklishin
Copy link
Member

I don't know why but I cannot gem push to rubygems.org, it runs into a network connectivity issue of some kind.

@michaelklishin
Copy link
Member

Apparently this is why: https://github.com/jruby/jruby/issues/6871

@michaelklishin
Copy link
Member

OK, built the gem on JRuby 9.3 and pushed using CRuby 3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants