-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace java_kind_of?
with kind_of?
to support JRuby-9.3.0.0
#156
Replace java_kind_of?
with kind_of?
to support JRuby-9.3.0.0
#156
Conversation
@michaelklishin can you please have a look? |
@olleolleolle I have seen your comment on the JRuby issue (jruby/jruby#6862 (comment)). FYI: The test for the long header conversion (https://github.com/ruby-amqp/march_hare/blob/master/spec/higher_level_api/integration/basic_consume_spec.rb#L158) worked for me locally with this branch ( |
@ThomasKoppensteiner That sounds good. I'm in favour of the change. In order for it to be visible for everyone, I'd love to have CI runs. |
Sorry for the inconvenience removing this method! It has been around since very old Java integration days, but since we started mimicking the Java class hierarchy with Ruby types (like 15 years ago) it has not been needed. I guess you really never can delete anything! Let us know if there are any further issues here. |
Rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you! That was easier than I expected it to ;) |
Thank you for merging the PRs. |
I don't know why but I cannot |
Apparently this is why: https://github.com/jruby/jruby/issues/6871 |
OK, built the gem on JRuby 9.3 and pushed using CRuby 3.0. |
Fixes Issue: #155