Remove monkey patching on Module #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjsk-stripe
force-pushed
the
remove-monkey-patching
branch
from
e19aff7
to
5c0176b
Compare
pjsk-stripe
commented
Mar 29, 2023
| @node.at_xpath(*args) | ||
| end | ||
|
|
||
| def xpath(*args) |
There was a problem hiding this comment.
arguments match what is expected in the docs
pjsk-stripe
commented
Mar 29, 2023
|
|
||
| # TODO: Should create a docx object from this | ||
| def parent(type = '*') | ||
| @node.at_xpath("./parent::#{type}") | ||
| end | ||
|
|
||
| def at_xpath(*args) |
There was a problem hiding this comment.
arguments match what is expected in the docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use this gem and one particular issue we're experiencing comes from this monkey patch which adds activesupport-like delegators directly onto
Modulewhich mutates basically everything in our codebase by nature of code inheritingClass.It looks like this monkeypatch only exists to support two separate
delegatecalls supporting four separate methods.This PR replaces those delegates with regular ol' ruby methods and allows us to delete the monkeypatch (along with 100+ lines of code)
This fixes #131
✅ Tests pass in this new configuration.