Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont indent assignment blocks #216

Merged
merged 2 commits into from
Jan 11, 2020
Merged

Dont indent assignment blocks #216

merged 2 commits into from
Jan 11, 2020

Conversation

gingermusketeer
Copy link
Member

Resolves #90

@gingermusketeer
Don't indent assignment blocks
a4a733a 
Why: Indenting the assignment blocks goes against a goal of Rufo which is to minimize version control diffs between changes.

For example with the previous setup we would get:
```diff
< a = if true
<       1
<     else
<       2
<     end
---
> a_new_name = if true
>                1
>              else
>                2
>              end
```
Now we have:
```diff
< a = if true
---
> a_new_name = if true
```
@gingermusketeer
Start block on assignment line
941c166
@gingermusketeer gingermusketeer merged commit 3c4aa76 into master Jan 11, 2020
@gingermusketeer gingermusketeer deleted the dont-indent-assignment-blocks branch January 11, 2020 17:55
@gingermusketeer gingermusketeer mentioned this pull request Jan 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

alignment agnosticism
1 participant
@gingermusketeer