Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove indent size config #30

Merged
merged 1 commit into from
Oct 14, 2017
Merged

Remove indent size config #30

merged 1 commit into from
Oct 14, 2017

Conversation

gingermusketeer
Copy link
Member

Removes the configurability of the indentation size as part of #2.

splattael
splattael approved these changes Oct 13, 2017
View reviewed changes
Copy link
Member

@splattael splattael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👍

@splattael splattael requested review from bessey and danielma October 13, 2017 06:52
@mjago mjago self-requested a review October 13, 2017 08:37
mjago
mjago approved these changes Oct 13, 2017
View reviewed changes
Copy link
Member

@mjago mjago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@bessey
Copy link
Member

bessey commented Oct 14, 2017

Great!

@bessey bessey merged commit 274aeab into ruby-formatter:master Oct 14, 2017
@gingermusketeer gingermusketeer deleted the remove-indent-size-config branch October 14, 2017 21:55
@gingermusketeer
Copy link
Member Author

I have removed this config option from the settings page on the wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielma danielma danielma approved these changes

@bessey bessey bessey approved these changes

@splattael splattael splattael approved these changes

@mjago mjago mjago approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gingermusketeer @bessey @mjago @splattael @danielma