Change trailing commas config #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: So that consistency is enforced across the code base.
bessey
approved these changes
Oct 15, 2017
lucerion
approved these changes
Oct 16, 2017
|
I think I will personally tend to configure no trailing comma but I'm happy to go with the majority view. It may be worth noting that the defaults on both prettier and rubocop (I think) is no multiline trailing comma - configuration allowed, so we should expect disapproval. |
mjago
approved these changes
Oct 16, 2017
danielma
approved these changes
Oct 16, 2017
mjago
approved these changes
Oct 16, 2017
There was a problem hiding this comment.
@gingermusketeer I've noticed one small thing - last_has_comma can now disappear altogether
|
Thanks @gingermusketeer 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the default for trailing commas to be
:always. The reason I opted for this is so that consistency is enforced.This also removes the
:dynamicoption for the same reason as above.While I think that
:alwaysis the better default, due to minimizing diff noise, I do think that we need to a configuration option for this. Thoughts?