Locale::Middleware never uses Accept-Language

[sakuro]

locale 2.1.3

Gist

Locale::Middleware calls Locale::Driver::CGI#set_request with
[request["lang"]] as the first argument(query_lang).

locale/lib/locale/middleware.rb

Lines 30 to 33 in b59486e

	Locale.set_request([request["lang"]],
	[request.cookies["lang"]],
	environment["HTTP_ACCEPT_LANGUAGE"],
	environment["HTTP_ACCEPT_CHARSET"])

It is [nil] when lang is not fed and it is added to locales as Locale::Tag::Irregular: en. So locales always becomes non-empty here and unless locales.size > 0 clause prevents using values from Accept-Language header.

This applies to lang from both query string and cookie.

locale/lib/locale/driver/cgi.rb

Lines 45 to 60 in b59486e

	if langs = req[:query_langs]
	langs.each do |lang|
	locales << Locale::Tag.parse(lang)
	end
	end
	unless locales.size > 0
	# COOKIE "lang"
	if langs = req[:cookie_langs]
	langs.each do |lang|
	locales << Locale::Tag.parse(lang) if lang.size > 0
	end
	end
	end
	unless locales.size > 0

[kou]

Good catch!

Do you want to open a PR for this? It seems that we can fix this by adding .compact to [request["lang"]] and [request.cookies["lang"]].

[sakuro]

#16