Skip to content

In ls-files do not unescape file paths with eval #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: ls-tree optional recursion into subtrees
merged 1 commit into from
Dec 9, 2022
Merged

In ls-files do not unescape file paths with eval #602

merged 1 commit into from
Dec 9, 2022
+25 −1

Conversation

@jcouball
Copy link
Member

@jcouball jcouball commented Dec 9, 2022

Signed-off-by: James Couball jcouball@yahoo.com

  • Ensure all commits include DCO sign-off.
  • Ensure that your contributions pass unit testing.
  • Ensure that your contributions contain documentation if applicable.

Description

In Lib#ls_files, do not use eval to unescape paths. Instead, use Git::EscapedPath to unescape the path.

@jcouball
In ls-files do not unescape file paths with eval
38fb629 
Signed-off-by: James Couball <jcouball@yahoo.com>
@jcouball jcouball merged commit 4fe8738 into master Dec 9, 2022
@jcouball jcouball deleted the remove_eval branch December 9, 2022 22:17
@jcouball jcouball mentioned this pull request Dec 14, 2022
Merged
@jcouball jcouball mentioned this pull request Feb 2, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jcouball