Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #249: leaking of options and internals in default serialization. #250

Merged
merged 1 commit into from
Nov 20, 2016
Merged

Fix #249: leaking of options and internals in default serialization. #250

merged 1 commit into from
Nov 20, 2016

Conversation

dblock
Copy link
Member

@dblock dblock commented Nov 20, 2016 •
edited
Loading

I think the best option is to make inspect serialize the object.

@dblock
Copy link
Member Author

dblock commented Nov 20, 2016

@idyll @marshall-lee @LeFnord would appreciate any +/- 1 comments

@dblock
Copy link
Member Author

dblock commented Nov 20, 2016

/cc: @KingsleyKelly

@dblock dblock force-pushed the fix-249 branch 2 times, most recently from 4833e43 to 4eede6b Compare November 20, 2016 15:07
@LeFnord
Copy link
Member

LeFnord commented Nov 20, 2016

0.6.0 release ?

@LeFnord LeFnord merged commit 4ace860 into ruby-grape:master Nov 20, 2016
@dblock dblock deleted the fix-249 branch November 21, 2016 03:07
@dblock
Copy link
Member Author

dblock commented Nov 21, 2016

@LeFnord done.

@CGA1123 CGA1123 mentioned this pull request Nov 29, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeFnord LeFnord LeFnord approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dblock @LeFnord