Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate .rubocop_todo.yml #120

Closed
wants to merge 2 commits into from

Conversation

kakubin
Copy link

@kakubin kakubin commented Jul 25, 2024

cop RSpec/FilePath is now obsoleted.

following message was shown when rubocop executed.

Error: The `RSpec/FilePath` cop has been split into `RSpec/SpecFilePathFormat` and `RSpec/SpecFilePathSuffix`.
(obsolete configuration found in .rubocop_todo.yml, please update it)

see also: rubocop/rubocop-rspec#1723

@kakubin kakubin force-pushed the update_rubocop_todo branch from 9005031 to a8292c8 Compare July 25, 2024 11:51
@dblock
Copy link
Member

dblock commented Jul 25, 2024

Maybe use this opportunity to upgrade rubocop to a newer version and lock to it?

@kakubin kakubin force-pushed the update_rubocop_todo branch 2 times, most recently from 901557b to be3de5e Compare July 27, 2024 22:33
@@ -25,7 +25,7 @@ group :development, :test do
gem 'rubocop'
gem 'rubocop-capybara'
gem 'rubocop-rake'
gem 'rubocop-rspec'
gem 'rubocop-rspec', '>= 3.0.0'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kakubin
Copy link
Author

kakubin commented Jul 29, 2024

@dblock
I think the cause of downcasing header keys is in this diff.
スクリーンショット 2024-07-29 22 49 47
Do you know anything?

@dblock
Copy link
Member

dblock commented Jul 29, 2024

Yes, the grape upgrade is not the intent of this PR, and it's hidden behind what you're trying to do.

You have two choices:

  1. Lock version of grape and just do the rubocop upgrade here. Do a separate PR to upgrade grape.
  2. Do a bundle update for everything, fix tests as needed.

kakubin added 2 commits August 3, 2024 17:27
cop `RSpec/FilePath` is now obsoleted.

following message was shown when rubocop executed.

```
Error: The `RSpec/FilePath` cop has been split into `RSpec/SpecFilePathFormat` and `RSpec/SpecFilePathSuffix`.
(obsolete configuration found in .rubocop_todo.yml, please update it)
```
@kakubin kakubin force-pushed the update_rubocop_todo branch from be3de5e to ad773c3 Compare August 3, 2024 08:33
@kakubin
Copy link
Author

kakubin commented Aug 3, 2024

@dblock
Thank you for your advice :)
Since it is a specification that different versions of grape handle a header key differently, I think this change makes sense.

@grape-bot
Copy link

1 Message
📖 We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Generated by 🚫 Danger

@padde
Copy link
Contributor

padde commented Sep 15, 2024

@dblock probably obsoleted by #124

@kakubin kakubin closed this Sep 16, 2024
@kakubin kakubin deleted the update_rubocop_todo branch September 16, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants