Rails 5 support #70
Rails 5 support #70
Conversation
serggl
force-pushed
the
feature/rails5
branch
from
5b4c1ff to
d059633
Compare
| @@ -3,10 +3,16 @@ | |||
| module GrapeSwaggerRails | |||
| class Options < OpenStruct | |||
| def before_filter(&block) | |||
| ActiveSupport::Deprecation.warn('this option is deprecated and going to be removed soon. ' \ | |||
There was a problem hiding this comment.
Should probably start with a capital T to be consistent and have a period after instead?
There was a problem hiding this comment.
what should be the time period?
There was a problem hiding this comment.
I would change "soon" to "version X.Y.Z", whatever the next major one is.
There was a problem hiding this comment.
Not sure what will be the next major one, so changed to 0.3.0. Is it ok?
|
This looks good. We need an UPGRADING document like https://github.com/ruby-grape/grape/blob/master/UPGRADING.md, could you add one please? You don't have to fight rubocop, if something doesn't make sense (like a line too long), just run |
|
serggl
force-pushed
the
feature/rails5
branch
from
d1cf089 to
2ceafaa
Compare
|
Merged, thank you. For versioning pros, what's should we do wrt versioning for this deprecation, should it be 0.3.0 or is deprecating something ok for a minor increment? |
|
Also @serggl you seem to know what you're doing, want to help out with this project? Maybe cut the next release? If you're up for it tell me your rubygems email and I'll add you to project collaborators. |
|
@dblock according to semantic versioning (semver.org) this should be a minor version increment, so I guess this should be 0.3.0 Also yes, I think I can help a bit with this project since I use grape/swagger a lot in my day to day work. My rubygems email is sergey.glukhov@gmail.com |
|
Welcome @serggl. If you can bump the version as per semver and make a release following https://github.com/ruby-grape/grape-swagger-rails/blob/master/RELEASING.md that'd be great! |
|
Also @aschuster3 has been very active in this project, keep things publicly visible, I opened #72 for a release. |
before_filterusages withbefore_actionGrapeSwaggerRails.options.before_filteroption