-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authorization header issue before initialize SwaggerUI
#73
base: master
Are you sure you want to change the base?
Authorization header issue before initialize SwaggerUI
#73
Conversation
Here's an example of a CHANGELOG.md entry: * [#73](https://github.com/ruby-grape/grape-swagger-rails/pull/73): Authorization header issue before initialize `SwaggerUI` - [@mur-wtag](https://github.com/mur-wtag). Generated by 🚫 danger |
Do you think you can write a test that actually reproduces this? |
CORE-826
CORE-826
CORE-826
@mur-wtag I think the idea was to create a capybara/selenium spec that with will fail unless your fix is available. See https://github.com/ruby-grape/grape-swagger-rails/blob/master/spec/features/swagger_spec.rb to find spec samples |
+1 @serggl, right now these specs pass, so make a spec that fails, apply a fix and see it succeed |
CORE-826
Bug Description:
Consider this code block:
This code block going to initialize
SwaggerUi
.But To initialize
SwaggerUi
we need to have authorization header. And the insideonComplete
we are addingAuthorization Header
by callingaddApiKeyAuthorization()
.So, initialization of
SwaggerUi
fails and triggersonFaiulre
:pAnd this resolution is to add header before initialize
SwaggerUI
Some discussions: