Added the token api_auth type #84
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hermann Mayer <hermann.mayer92@gmail.com>
|
Needs tests and CHANGELOG please. |
|
on my way :) |
Signed-off-by: Hermann Mayer <hermann.mayer92@gmail.com>
serggl
approved these changes
Jul 26, 2018
|
What about tests. There're actually working tests for these scenarios in https://github.com/ruby-grape/grape-swagger-rails/blob/master/spec/features/swagger_spec.rb#L84. Thanks! |
|
I close this PR due to the long delay of my side and due to the fact that my organization has now a bunch of apps which use my fork/master version which would break on all sides when I squash the commits. Follow up: #86 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys, first things first: thanks for this great gem!
It would be quite useful to have a new
tokenauthentication type,which follows the Rails convention. So the
Authorizationheaderlooks like this:
This PR allows the usage of this authentication.