Modify full entity name to be RFC3986 compliant #797 #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 17, 2020 09:13
Signed-off-by: Garrett Blehm <garrett.blehm@cerner.com>
Signed-off-by: Garrett Blehm <garrett.blehm@cerner.com>
|
thanks @GarrettB71 … for spotting and fixing it |
|
mmh a bit strange, travis says it's all fine, but GH ??? … please can you push again to trigger the travis pipeline, thanks |
|
I believe the build is failing due to a change in |
|
thanks @GarrettB71 yeap … that was it, it should be fixed now … I'll change onle the Upgrading to the next version, which will be 1.2.0 |
|
please can you adapt this spec inheritance_and_discriminator_spec.rb#L51-L53 … thanks and sorry |
Signed-off-by: Garrett Blehm <garrett.blehm@cerner.com>
|
thanks @GarrettB71 |
aka-momo
pushed a commit
to aka-momo/grape-swagger
that referenced
this pull request
Feb 8, 2023
…grape#798) * Modify full entity name to be RFC3986 compliant ruby-grape#797 Signed-off-by: Garrett Blehm <garrett.blehm@cerner.com> * Update changelog and upgrading files Signed-off-by: Garrett Blehm <garrett.blehm@cerner.com> * Update Changelog * Corrects next version * Modified ineritance and discriminator spec Signed-off-by: Garrett Blehm <garrett.blehm@cerner.com> Co-authored-by: Garrett Blehm <garrett.blehm@cerner.com> Co-authored-by: peter scholz <pscholz.le@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Garrett Blehm garrett.blehm@cerner.com
Addresses issue #797.
Updated
parse_entity_namemethod to use RFC3986 compliant_instead of::as separator.