Fixes (restores) route ordering #859
Conversation
Satisfies rubocop
|
I have one failing test, but I have to wonder if it's due to a bug in grape. The purported solution in #631 may have simply masked the problem. If in fact the issue is with grape-swagger I don't think the appropriate solution is to simply reverse the order of the route set. In any event, the test case seems to me rather odd. I couldn't find anything quite like it in grape's docs or specs (ofc I could well have missed it). |
be a blocker to making the changes in this PR. While there does not appear to be a grape test with the same setup, the spec at https://github.com/ruby-grape/grape/blob/e3451c892abd82c15f0937d7f464613ae715a73d/spec/grape/api_spec.rb#L1025-L1045 suggests that mounts do not overwrite.
|
Please note that this change may reintroduce the issue that #631 attempted to solved, albeit IMO incorrectly. |
|
I know that I have dodged a problem by removing a test (and I haven't yet tried adding it back), but this route ordering problem still exists. I love this project, and I'd like to help fix this. I have merged in the latest changes and all other tests are passing. |
|
thanks for finishing it |
This restores the route ordering which was changed in #631.
Fixes #679