Enable Schema definitions for DELETE request body params #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numbata
force-pushed
the
delete_action_params_schema_definition
branch
2 times, most recently
from
1715387 to
599a486
Compare
numbata
commented
Apr 20, 2024
numbata
changed the title
numbata
force-pushed
the
delete_action_params_schema_definition
branch
from
599a486 to
630eece
Compare
|
@LeFnord wdyt about the PR? Feel free to let me know if I should stop pinging you and/or should communicate in a different way. |
no, it's fine, and thanks for remembering |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows grape-swagger to document body parameters with schema definitions for DELETE requests.
The change aligns DELETE requests with POST, PUT, and PATCH, which already support this.