Skip to content

Commit

Permalink
Revert "Update rack from 1.5.2 to 1.5.5"
Browse files Browse the repository at this point in the history
This reverts commit 022a642.

rm useless appraisal

ref #1813, #1066
  • Loading branch information
dm1try committed Nov 4, 2018
1 parent d752a65 commit 87b6243
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 46 deletions.
6 changes: 0 additions & 6 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ matrix:
gemfile: Gemfile
- rvm: 2.5.3
gemfile: gemfiles/rack_edge.gemfile
- rvm: 2.5.3
gemfile: gemfiles/rack_1.5.5.gemfile
- rvm: 2.5.3
gemfile: gemfiles/rails_edge.gemfile
- rvm: 2.5.3
Expand All @@ -31,16 +29,12 @@ matrix:
gemfile: Gemfile
- rvm: 2.4.5
gemfile: gemfiles/rack_edge.gemfile
- rvm: 2.4.5
gemfile: gemfiles/rack_1.5.5.gemfile
- rvm: 2.4.5
gemfile: gemfiles/rails_5.gemfile
- rvm: 2.3.8
gemfile: Gemfile
- rvm: 2.3.8
gemfile: gemfiles/rack_edge.gemfile
- rvm: 2.3.8
gemfile: gemfiles/rack_1.5.5.gemfile
- rvm: 2.3.8
gemfile: gemfiles/rails_5.gemfile
- rvm: 2.2.10
Expand Down
4 changes: 0 additions & 4 deletions Appraisals
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@ appraise 'rails-5' do
gem 'rails', '5.2.1'
end

appraise 'rack-1.5.5' do
gem 'rack', '1.5.5'
end

appraise 'rails-edge' do
gem 'rails', github: 'rails/rails'
end
Expand Down
35 changes: 0 additions & 35 deletions gemfiles/rack_1.5.5.gemfile

This file was deleted.

2 changes: 1 addition & 1 deletion spec/grape/integration/rack_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
unless RUBY_PLATFORM == 'java'
major, minor, patch = Rack.release.split('.').map(&:to_i)
patch ||= 0 # rack <= 1.5.2 does not specify patch version
pending 'Rack 1.5.5 or 1.6.1 required' unless major >= 2 || (major >= 1 && ((minor == 5 && patch >= 5) || (minor >= 6)))
pending 'Rack 1.5.3 or 1.6.1 required' unless major >= 2 || (major >= 1 && ((minor == 5 && patch >= 3) || (minor >= 6)))
end

expect(JSON.parse(app.call(env)[2].body.first)['params_keys']).to match_array('test')
Expand Down

0 comments on commit 87b6243

Please sign in to comment.